Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unnecessary usages of useEventCallback #28910

Merged
merged 1 commit into from
Oct 20, 2021
Merged

[core] Remove unnecessary usages of useEventCallback #28910

merged 1 commit into from
Oct 20, 2021

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented Oct 8, 2021

It's best to review this PR without whitespace changes.

I've removed references to useEventCallback where as far as I can tell, there would be no difference from the way it's currently used:

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 8, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 460a21f

@mnajdova mnajdova added new feature New feature or request package: base-ui Specific to @mui/base labels Oct 15, 2021
@mnajdova
Copy link
Member

in SliderUnstyled the event handlers that I've removed it from, were passed directly to and React doesn't require them to have a stable reference: https://twitter.com/dan_abramov/status/1102708434821173249

Nice 👍

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All changes make sense to me. Thanks for looking into this 🙏

@NMinhNguyen
Copy link
Contributor Author

Thank you @mnajdova!

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@mnajdova mnajdova merged commit 6ff9e79 into mui:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants