Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Add TipsAndUpdate icon #29004

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Oct 12, 2021

Closes #29000

This PR de-excludes TipsAndUpdates icon.

diff --git a/packages/mui-icons-material/scripts/download.js b/packages/mui-icons-material/scripts/download.js
index 6d9a66b959..5a616ef905 100644
--- a/packages/mui-icons-material/scripts/download.js
+++ b/packages/mui-icons-material/scripts/download.js
@@ -39,7 +39,6 @@ const ignoredIconNames = new Set([
   'real_estate_agent',
   'recycling',
   'space_dashboard',
-  'tips_and_updates',
   'water_drop',
   'waving_hand',
 ]);

code sandbox: https://codesandbox.io/s/naughty-feather-2f9y2?file=/src/App.tsx

@hbjORbj hbjORbj added bug 🐛 Something doesn't work package: icons Specific to @mui/icons labels Oct 12, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 12, 2021

No bundle size changes

Generated by 🚫 dangerJS against da2fcd3

@hbjORbj hbjORbj changed the title [@mui/icons-material] Add TipsAndUpdate icon Darft: [@mui/icons-material] Add TipsAndUpdate icon Oct 12, 2021
@hbjORbj hbjORbj changed the title Darft: [@mui/icons-material] Add TipsAndUpdate icon WIP: [@mui/icons-material] Add TipsAndUpdate icon Oct 12, 2021
@hbjORbj hbjORbj changed the title WIP: [@mui/icons-material] Add TipsAndUpdate icon [WIP][@mui/icons-material] Add TipsAndUpdate icon Oct 12, 2021
@hbjORbj hbjORbj changed the title [WIP][@mui/icons-material] Add TipsAndUpdate icon [WIP][icons] Add TipsAndUpdate icon Oct 12, 2021
@hbjORbj hbjORbj force-pushed the add-material-icon branch 2 times, most recently from dcf5227 to 8053fda Compare October 12, 2021 11:40
@eps1lon
Copy link
Member

eps1lon commented Oct 13, 2021

Do you know why it was excluded?

@hbjORbj
Copy link
Member Author

hbjORbj commented Oct 13, 2021

Do you know why it was excluded?

@eps1lon The comment says the following:

// This is just a list of new icons.
// In the future we might change what icons we want to exclude (e.g. by popularity)

Do you think we should keep excluding it?

@hbjORbj hbjORbj changed the title [WIP][icons] Add TipsAndUpdate icon [icons] Add TipsAndUpdate icon Oct 13, 2021
@eps1lon
Copy link
Member

eps1lon commented Oct 13, 2021

Well we already have problems with the size of the icons package. This PR creates a precedence that we actually don't want to ignore new icons. Up to you what direction you want to go.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hbjORbj hbjORbj merged commit 81578f0 into mui:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icons] TipsAndUpdates icon is missing
4 participants