Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.2.5 #30288

Merged
merged 4 commits into from
Dec 20, 2021
Merged

v5.2.5 #30288

merged 4 commits into from
Dec 20, 2021

Conversation

michaldudak
Copy link
Member

5.2.5 release

@michaldudak michaldudak requested a review from a team December 20, 2021 12:30
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 20, 2021

No bundle size changes

Generated by 🚫 dangerJS against 68cab9b

CHANGELOG.md Outdated

### `@mui/[email protected]`

- &#8203;<!-- 22 -->[Badge] Add tests for `anchorOrigin` prop (#30147) @daniel-sachs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can probably go to the "Core" section, it's not something that affect the users of the library

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "public" changes section is getting even poorer ;)

@@ -1,6 +1,6 @@
{
"name": "test",
"version": "5.0.2",
"version": "5.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


A big thanks to the 14 contributors who made this release possible. Here are some highlights ✨:

- 🛠 This release mostly improves what's behind the scenes: infrastructure and tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 🛠 This release mostly improves what's behind the scenes: infrastructure and tests
- 🛠 Improve infrastructure and increase test coverage

I think the shorter the better for posting on twitter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add a bit of variety to these cold statements ;) As for Twitter, we don't need to quote the release quotes exactly there.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package versions look good to me.

CHANGELOG.md Outdated Show resolved Hide resolved
@michaldudak michaldudak merged commit f8697de into mui:master Dec 20, 2021
@michaldudak michaldudak deleted the release/5.2.5 branch December 20, 2021 14:47
@oliviertassinari oliviertassinari added the release We are shipping :D label Dec 21, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I see that we don't have the &#8203;<!-- 14 --> comments. Is it on purpose? A bit of history: #24614 (comment).

- [docs] Add to migration doc about ref type specificity (#30114) @hbjORbj
- [docs] Add script to clone pages (#30107) @siriwatknp
- [docs] Correct colors in breakpoints documentation (#30219) @michaldudak
- [docs] Sync icon search UI state with the url (#30075) @Janpot
Copy link
Member

@oliviertassinari oliviertassinari Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak
Copy link
Member Author

Interesting, I see that we don't have the ​ comments. Is it on purpose? A bit of history: #24614 (comment).

Yes, I removed the comments (but I kept the order) to reduce the noise when the changelog is read as plain text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants