Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Bump jscodeshift to remove colors dependency #30578

Merged
merged 2 commits into from
Jan 11, 2022
Merged

[codemod] Bump jscodeshift to remove colors dependency #30578

merged 2 commits into from
Jan 11, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 11, 2022 •
edited
Loading

Close #30565

TL;DR
jscodeshift had colors as dependency which contains an intentional DoS. They have replaced with chalk in v0.13.1

facebook/jscodeshift@7cf9969

@siriwatknp siriwatknp added the package: codemod Specific to @mui/codemod label Jan 11, 2022
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 11, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against f9e4967

@siriwatknp siriwatknp merged commit b970a90 into mui:master Jan 11, 2022
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@siriwatknp @wladimirguerra
[codemod] Bump jscodeshift to remove colors dependency (mui#30578)
3d62392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: codemod Specific to @mui/codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@mui/codemod outputs mess
4 participants
@siriwatknp @mui-pr-bot @mnajdova @hbjORbj