-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add designer position page #30708
Conversation
They're not meant for this PR, not sure why they leaked again 😕 Ignore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting closer 👍
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
…terial-ui into designer-position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, I have pushed a few polishes, I can't find anything else to improve. Maybe @mbrookes will want to have a look but not sure.
Please review suggested changes here: https://github.com/danilo-leal/material-ui/pull/1/files |
@mbrookes I have applied suggestions on your PR to restore fixes that go introduced after you started the suggestions. Once merged, I think that we should use the new wording to update the other open roles (I have updated them to follow the same line). |
A bit off topic but for some reason, adding a |
@danilo-leal I assume that it's because of https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md#md026---trailing-punctuation-in-heading which motivate why with https://cirosantilli.com/markdown-style-guide/#punctuation-at-the-end-of-headers. I think that we could change this header altogether if we wanted to invest more time, but it's probably fine, as is? |
Co-authored-by: Olivier Tassinari <[email protected]>
Designers out there, come in and apply! :)
https://deploy-preview-30708--material-ui.netlify.app/company/designer/
Based on https://www.notion.so/mui-org/Designer-job-ad-page-bd6818d4dd1648ac8ce3180b59eb27e0