Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add designer position page #30708

Merged
merged 24 commits into from
Jan 28, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jan 20, 2022

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Jan 20, 2022
They're not meant for this PR, not sure why they leaked again 😕  Ignore this.
@mui-bot
Copy link

mui-bot commented Jan 20, 2022

No bundle size changes

Generated by 🚫 dangerJS against 709434f

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting closer 👍

docs/src/pages/company/careers/product-designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/product-designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/product-designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/product-designer.md Outdated Show resolved Hide resolved
docs/pages/careers.tsx Outdated Show resolved Hide resolved
docs/pages/careers.tsx Outdated Show resolved Hide resolved
docs/src/pages/company/careers/product-designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/designer.md Outdated Show resolved Hide resolved
docs/src/pages/company/careers/designer.md Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, I have pushed a few polishes, I can't find anything else to improve. Maybe @mbrookes will want to have a look but not sure.

@mbrookes
Copy link
Member

Please review suggested changes here: https://github.com/danilo-leal/material-ui/pull/1/files

@oliviertassinari
Copy link
Member

@mbrookes I have applied suggestions on your PR to restore fixes that go introduced after you started the suggestions. Once merged, I think that we should use the new wording to update the other open roles (I have updated them to follow the same line).

@danilo-leal
Copy link
Contributor Author

A bit off topic but for some reason, adding a : in a heading, like ### You might fit for this role if you:, fails the lint test. That's why I haven't added it.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 24, 2022

for some reason

@danilo-leal I assume that it's because of https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md#md026---trailing-punctuation-in-heading which motivate why with https://cirosantilli.com/markdown-style-guide/#punctuation-at-the-end-of-headers. I think that we could change this header altogether if we wanted to invest more time, but it's probably fine, as is?

@danilo-leal danilo-leal merged commit aed212d into mui:master Jan 28, 2022
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants