Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add notifications for the blog posts #30852

Merged
merged 3 commits into from
Feb 1, 2022
Merged

[docs] Add notifications for the blog posts #30852

merged 3 commits into from
Feb 1, 2022

Conversation

siriwatknp
Copy link
Member

Screen Shot 2565-01-31 at 17 15 03

Screen Shot 2565-01-31 at 17 14 45

@siriwatknp siriwatknp requested review from oliviertassinari, mbrookes and a team January 31, 2022 10:15
@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Jan 31, 2022
@mui-bot
Copy link

mui-bot commented Jan 31, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 2a67871

@siriwatknp
Copy link
Member Author

siriwatknp commented Jan 31, 2022 •
edited
Loading

@mbrookes @oliviertassinari @DanailH Another option for the title is to start with the product name using [] and bold text:

  • 🚀 [Material UI] Callback support in style overrides
  • 🚀 [Data Grid] Row Grouping feature

@mnajdova
Copy link
Member

another option for the title is to start with the product name using [] and bold text

+1 for this

siriwatknp
siriwatknp commented Jan 31, 2022
View reviewed changes
docs/notifications.json Outdated Show resolved Hide resolved
siriwatknp
siriwatknp commented Jan 31, 2022
View reviewed changes
docs/notifications.json Outdated Show resolved Hide resolved
@siriwatknp @cherniavskii
Apply suggestions from code review
2bd864a 
Co-authored-by: Andrew Cherniavskii <[email protected]>
danilo-leal
danilo-leal approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to match the blog post titles.

siriwatknp
siriwatknp commented Feb 1, 2022
View reviewed changes
docs/notifications.json Outdated Show resolved Hide resolved
@mnajdova mnajdova merged commit 96ffba5 into mui:master Feb 1, 2022
@danilo-leal
Copy link
Contributor

Not sure if it is just me but it seems that the <b> tag is not working on the Notifications 😕

Screen Shot 2022-02-01 at 10 09 50

mbrookes
mbrookes reviewed Feb 2, 2022
View reviewed changes
docs/notifications.json
},
{
"id": 56,
"title": "🚀 [<b>Data Grid</b>] Introducing Row Grouping feature",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Introducing the Row Grouping feature"

@siriwatknp
Copy link
Member Author

Not sure if it is just me but it seems that the <b> tag is not working on the Notifications 😕

Screen Shot 2022-02-01 at 10 09 50

Fixed in #30862

wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@siriwatknp @wladimirguerra
[docs] Add notifications for the blog posts (mui#30852)
a53dd79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii left review comments

@mbrookes mbrookes mbrookes left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova mnajdova approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@siriwatknp @mui-bot @mnajdova @danilo-leal @mbrookes @cherniavskii