[ButtonUnstyled] Allow receiving focus when disabled #32090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: button
|
@samuelsycamore I'd appreciate a review of the docs. |
mnajdova
reviewed
Apr 5, 2022
| * If `true`, allows a disabled button to receive focus. | ||
| * @default false | ||
| */ | ||
| allowFocusWhenDisabled?: boolean; |
There was a problem hiding this comment.
Suggested change
| allowFocusWhenDisabled?: boolean; | |
| focusableWhenDisabled?: boolean; |
Maybe, not sure :)
There was a problem hiding this comment.
Yeah, sounds better :)
mnajdova
reviewed
Apr 5, 2022
| @@ -34,6 +34,21 @@ In addition to HTML elements, you can also use SVGs with the `ButtonUnstyled` co | |||
|
|
|||
| {{"demo": "UnstyledButtonCustom.js"}} | |||
|
|
|||
| ## Focus of disabled buttons | |||
|
|
|||
| Similarly to the native `<button>`, the `ButtonUnstyled` component can't receive focus when it's disabled. | |||
There was a problem hiding this comment.
Maybe expand on when this would be a good use-cases (for example MenuItem) and why. For example, in some cases, disabled elements that are required for completing a step (or are just generally too important to be missed) should be focusable with TAB key.
There was a problem hiding this comment.
👍 I explained how this may be important for accessibility and shared that we use this internally for the menu button. Does it look better for you now?
mnajdova
reviewed
Apr 6, 2022
mnajdova
approved these changes
Apr 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to receive focus when a button is disabled.
Used this new feature in MenuItemUnstyled, so that disabled items can be styled using the
Mui-focusVisibleclass.