Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix SEO issues #32282

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 13, 2022

This is a quick polish post #32241 and #32212, I wanted to finish a bit more what I started 😁. I hope this major docs site structure change we did (the kind you only do once every 3 years) will go smoothly from an SEO perspective. I suspect there will be some tweaks for us to do, but let's wait, keep a close eye on the analytics and see how it goes 🙌.

https://deploy-preview-32282--material-ui.netlify.app/material-ui/getting-started/installation/

@@ -393,7 +393,7 @@ function reduceChildRoutes(context) {
: false;
let firstChild = page.children[0];

if (firstChild.subheader && firstChild.subheader.children) {
if (firstChild.subheader && firstChild.children) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 13, 2022
@mui-bot
Copy link

mui-bot commented Apr 13, 2022

No bundle size changes

Generated by 🚫 dangerJS against ecb63e0

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, the rest looks good to me.

Co-authored-by: Siriwat K <[email protected]>
@oliviertassinari oliviertassinari merged commit ae39a8f into mui:master Apr 16, 2022
@oliviertassinari oliviertassinari deleted the fix-seo-issues-v3 branch April 16, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants