-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix SEO issues #32282
Merged
oliviertassinari
merged 3 commits into
mui:master
from
oliviertassinari:fix-seo-issues-v3
Apr 16, 2022
Merged
[docs] Fix SEO issues #32282
oliviertassinari
merged 3 commits into
mui:master
from
oliviertassinari:fix-seo-issues-v3
Apr 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -393,7 +393,7 @@ function reduceChildRoutes(context) { | |||
: false; | |||
let firstChild = page.children[0]; | |||
|
|||
if (firstChild.subheader && firstChild.subheader.children) { | |||
if (firstChild.subheader && firstChild.children) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
siriwatknp
reviewed
Apr 14, 2022
siriwatknp
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, the rest looks good to me.
Co-authored-by: Siriwat K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick polish post #32241 and #32212, I wanted to finish a bit more what I started 😁. I hope this major docs site structure change we did (the kind you only do once every 3 years) will go smoothly from an SEO perspective. I suspect there will be some tweaks for us to do, but let's wait, keep a close eye on the analytics and see how it goes 🙌.
https://deploy-preview-32282--material-ui.netlify.app/material-ui/getting-started/installation/