Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Remove scrollbar on x-axis #32291

Merged
merged 5 commits into from
May 16, 2022
Merged

[website] Remove scrollbar on x-axis #32291

merged 5 commits into from
May 16, 2022

Conversation

MrHBS
Copy link
Contributor

@MrHBS MrHBS commented Apr 14, 2022

@mui-bot
Copy link

mui-bot commented Apr 14, 2022

No bundle size changes

Generated by 🚫 dangerJS against bcf139a

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 14, 2022

Yes, much better, a follow-up on #29474. I think that they should be no scroll at all. Personally, I would revert #29141 and close #29119 as "won't fix".

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Apr 14, 2022
@oliviertassinari oliviertassinari changed the title [docs] remove scrollbar on x-axis [website] Remove scrollbar on x-axis Apr 14, 2022
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Apr 14, 2022
@MrHBS
Copy link
Contributor Author

MrHBS commented Apr 14, 2022

@oliviertassinari I agree with you. No scrolling would be better.

@danilo-leal
Copy link
Contributor

danilo-leal commented Apr 14, 2022

I'm moving in circles with this one a bit. When we first implemented it, I thought that no scroll was better, especially because the point of this section was more to act as an illustration—the components being interactive were meant to be a cool sort of "easter egg".

Then, when proposed to add the scroll bar due to wanting to interact with the components, that seemed to make sense, as depending on the browser window size, some of them get cut up.

Now, I'm back to the initial place where I'd go without scrollbars like both of you are suggesting, I do think it's meant to serve more as illustration than anything else.

@danilo-leal
Copy link
Contributor

Though if we move forward with this approach, we'd need to remove it from the other pages as well:

  • /core
  • /x

@danilo-leal danilo-leal merged commit 4e833ec into mui:master May 16, 2022
@oliviertassinari
Copy link
Member

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants