[core] Extract MuiPage interface to separate file
#32715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it can be imported without touching pagesApi.js
siriwatknp
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MUI X, we want to use
MuiPageinterface, but since we havenoImplicitAnyenabled, TS compiler throws the following error:To solve this issue, I've extracted interfaces to a separate file, so that we can use them in MUI X without issues.
pages.tsstill exports those interfaces to avoid changes in other parts of the codebase.I've also updated
scopePathnamesdescription to mention that it can use partial pathname (see mui/mui-x#4816)