Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge] Fix TypeScript error when adding style overrides for Badge #32745

Merged
merged 2 commits into from
May 12, 2022
Merged

[Badge] Fix TypeScript error when adding style overrides for Badge #32745

merged 2 commits into from
May 12, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented May 12, 2022 •
edited
Loading

Fixes #32699

Regression from #31974

Basically BadgeClasses should contain all the CSS classes.

@mui-bot
Copy link

mui-bot commented May 12, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 08d20ea

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review May 12, 2022 08:07
@ZeeshanTamboli ZeeshanTamboli added component: badge This is the name of the generic UI component, not the React module! regression A bug, but worse typescript labels May 12, 2022
michaldudak
michaldudak approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZeeshanTamboli ZeeshanTamboli merged commit 40643a8 into mui:master May 12, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/32669-fix-badge-styleOverrides-typescript-error branch May 12, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: badge This is the name of the generic UI component, not the React module! regression A bug, but worse typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Badge] TypeScript error when adding style overrides for Badge colors
3 participants
@ZeeshanTamboli @mui-bot @michaldudak