Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Miscellaneous fixes in MUI Base docs #33091

Merged
merged 2 commits into from
Jun 10, 2022
Merged

[docs] Miscellaneous fixes in MUI Base docs #33091

merged 2 commits into from
Jun 10, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jun 10, 2022 •
edited
Loading

I am working on SnackbarUnstyled component and thus noticed the following while reading the docs:

  1. It should be badge props slot, not input in the usage section.
  2. Code comment in useInput demo.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Jun 10, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix componentsProps usage docs [docs] Fix componentsProps example section in Usage docs Jun 10, 2022
@mui-bot
Copy link

mui-bot commented Jun 10, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 0907ef4

@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix componentsProps example section in Usage docs [docs] Miscellaneous fixes in Base docs Jun 10, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Miscellaneous fixes in Base docs [docs] Miscellaneous fixes in MUI Base docs Jun 10, 2022
michaldudak
michaldudak approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got an eye for detail! Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 1a30806 into mui:master Jun 10, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the fix-mui-base-usage-documentation branch June 10, 2022 08:55
@hzhz hzhz mentioned this pull request Jun 24, 2023
Open
@hzhz hzhz mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeshanTamboli @mui-bot @michaldudak