-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update bug template with generic instruction #33153
Merged
hbjORbj
merged 3 commits into
mui:master
from
joserodolfofreitas:update-github-bug-template
Jun 20, 2022
Merged
[core] Update bug template with generic instruction #33153
hbjORbj
merged 3 commits into
mui:master
from
joserodolfofreitas:update-github-bug-template
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joserodolfofreitas
changed the title
Recommend start the reproduction case from an example
Update Bug template with generic instruction
Jun 14, 2022
joserodolfofreitas
changed the title
Update Bug template with generic instruction
Update bug template with generic instruction
Jun 14, 2022
joserodolfofreitas
requested review from
mnajdova,
oliviertassinari and
samuelsycamore
June 14, 2022 21:44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
samuelsycamore
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text looks good!
michaldudak
reviewed
Jun 16, 2022
Co-authored-by: Olivier Tassinari <[email protected]> Co-authored-by: Michał Dudak <[email protected]>
hbjORbj
changed the title
Update bug template with generic instruction
[core] Update bug template with generic instruction
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
We started the discussion on improving our templates for bug reproduction at the MUI X repo.
@oliviertassinari suggested to bring the discussion to MUI Core, since we face here a closer problem with Joy, Base and etc.
The Problem
How can we help the users to quickly start a live reproduction demo?
Originally the problem was raised because our bug templates were all based on the
x-data-grid
andx-data-grid-pro
and we realized we'd need to update them as we released thex-date-pickers
and thePremium plan
.Other notes
Perhaps it makes sense to update the templates on MUI Core too.