Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Shadow DOM guide #33160

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jun 15, 2022

Follow up on #33007

I've noticed that Dialog in Shadow DOM looses its styles, so I've updated theme overrides to include MuiModal there.
Before: https://codesandbox.io/s/shadow-dom-forked-9dpix9 (open dialog in Shadow DOM first to see the issue)
After: https://codesandbox.io/s/shadow-dom-forked-11gq2b

I've already updated the Codesandbox demo on the doc page: https://mui.com/material-ui/guides/shadow-dom/#demo

@cherniavskii cherniavskii added the docs Improvements or additions to the documentation label Jun 15, 2022
@mui-bot
Copy link

mui-bot commented Jun 15, 2022

No bundle size changes

Generated by 🚫 dangerJS against f9a85c8

@cherniavskii cherniavskii requested a review from mnajdova June 15, 2022 09:48
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will solve the issue with all other components using the Modal, like the drawer components.

Note for myself: there are other guides that needs to be updated with this logic, for example the Tailwind CSS guide, for making sure that Tailwind classes will take precedence

@cherniavskii cherniavskii merged commit 20f0069 into mui:master Jun 16, 2022
@cherniavskii cherniavskii deleted the update-shadow-dom-guide branch June 16, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants