Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Add some missing props in useAutocomplete #33269

Merged
merged 4 commits into from
Jul 1, 2022
Merged

[Autocomplete] Add some missing props in useAutocomplete #33269

merged 4 commits into from
Jul 1, 2022

Conversation

henriqueholtz
Copy link
Contributor

@henriqueholtz henriqueholtz commented Jun 23, 2022 •
edited by ZeeshanTamboli
Loading

Description:

feat: Add some props at packages/mui-base/src/AutocompleteUnstyled/useAutocomplete.d.ts

  • disabled
  • readOnly
  • loading

Reference of default values and its descriptions: https://mui.com/material-ui/api/autocomplete/

Fixes #33239

Thanks.

@mui-bot
Copy link

mui-bot commented Jun 23, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 200a3af

@henriqueholtz
Copy link
Contributor Author

Some help? The scripts yarn prettier and yarn prettier check-changed don't updating nothing:

image

@henriqueholtz
Copy link
Contributor Author

Some help? The scripts yarn prettier and yarn prettier check-changed don't updating nothing:

image

@mnajdova please, can you help me? I want understood if it require some update of the code from my PR... Thanks

@mnajdova mnajdova changed the title feat: Add some props at packages/mui-base/src/AutocompleteUnstyled/useAutocomplete.d.ts [Autocomplete] Add some missing props in useAutocomplete Jun 24, 2022
@mnajdova
Copy link
Member

@mnajdova please, can you help me? I want understood if it require some update of the code from my PR... Thanks

You should be able to run yarn prettier in the root of the project. Not sure I understand what is the problem. Have you pushed the latest changes?

@henriqueholtz
Copy link
Contributor Author

@mnajdova please, can you help me? I want understood if it require some update of the code from my PR... Thanks

You should be able to run yarn prettier in the root of the project. Not sure I understand what is the problem. Have you pushed the latest changes?

@mnajdova I've take a look at scripts/prettier.js and see there one alternative , then I run yarn prettier:all and it worked for me, thanks!

michaldudak
michaldudak approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted the props alphabetically. Now, this looks good to be merged.
Thanks, @henriqueholtz!

@michaldudak michaldudak added typescript component: autocomplete This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jul 1, 2022
@michaldudak michaldudak merged commit 0d42c30 into mui:master Jul 1, 2022
@DaniBedz DaniBedz mentioned this pull request Aug 5, 2022
Closed
1 task
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@henriqueholtz @mnajdova @michaldudak
[Autocomplete] Add some missing props in useAutocomplete (mui#33269)
83f985b 
Co-authored-by: Marija Najdova <[email protected]>
Co-authored-by: Michał Dudak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useAutocomplete.d.ts does not included disabled & readOnly property
4 participants
@henriqueholtz @mui-bot @mnajdova @michaldudak