Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Link MUI Toolpad in mui.com #33287

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 24, 2022

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Jun 24, 2022
@mui-bot
Copy link

mui-bot commented Jun 24, 2022

No bundle size changes

Generated by 🚫 dangerJS against eddc131

@oliviertassinari oliviertassinari requested a review from Janpot June 24, 2022 23:13
/:lang/x/* https://material-ui-x.netlify.app/:lang/x/:splat 200

## MUI Toolpad
/_next/* https://mui-toolpad-docs.netlify.app/_next/:splat 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, did we try Next.js basePath before?

Copy link
Member Author

@oliviertassinari oliviertassinari Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tried this pattern to do the integration with MUI Store and Gatsby: https://github.com/mui/mui-store/blob/67f30e5ec9a48aa229b605040c566c58a1d75a0c/web/gatsby-config.js#L17: https://www.gatsbyjs.com/docs/how-to/previews-deploys-hosting/path-prefix/. The store used to be hosted as https://themes.material-ui.com/. pathPrefix was the fastest way to get the work done when we decided to move it to http://mui.com/store/ to improve SEO.

It simplifies the configuration on this file, however, we have to always do the mental conversion in our head between the localhost & live preview URLs on what will be the final URLs. I wouldn't say it has been a great DX so far on the store.

Comment on lines +378 to +382
/_next/* https://material-ui-x.netlify.app/_next/:splat 200
/static/x/* https://material-ui-x.netlify.app/static/x/:splat 200
/x/* https://material-ui-x.netlify.app/x/:splat 200
/r/x-* https://material-ui-x.netlify.app/r/x-:splat 200
/:lang/x/* https://material-ui-x.netlify.app/:lang/x/:splat 200
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the production deployment. It seems to make more sense.

@oliviertassinari oliviertassinari merged commit f317602 into mui:master Jul 2, 2022
@oliviertassinari oliviertassinari deleted the link-toolpad branch July 2, 2022 17:48
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants