Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectField] autoFocus enabled #3403

Closed
wants to merge 4 commits into from
Closed

[SelectField] autoFocus enabled #3403

wants to merge 4 commits into from

Conversation

DoubleU23
Copy link

see #3402

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 21, 2016
oliviertassinari
oliviertassinari reviewed Feb 21, 2016
View reviewed changes
src/SelectField/SelectField.jsx
@@ -20,9 +20,15 @@ function getStyles(props) {
}

const SelectField = React.createClass({
displayName: 'SelectField',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@DoubleU23 DoubleU23 closed this Feb 22, 2016
@DoubleU23 DoubleU23 reopened this Feb 22, 2016
@mbrookes mbrookes added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 25, 2016
@mbrookes mbrookes self-assigned this Mar 2, 2016
@mbrookes
Copy link
Member

mbrookes commented Mar 4, 2016

Hi @DoubleU23, I've picked up ownership of this PR and have been discussing it with some of the team. Since the long term goal is stateless controlled components, we've agreed that the better way to support this is to add an open and onRequestClose prop to DropDownMenu, then pass that down from SelectField .

Do you want to give open a go? If so, it might be cleaner to start with a fresh PR.

#3583 adds the needed onRequestClose.

@mbrookes mbrookes added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Mar 4, 2016
@mbrookes
Copy link
Member

mbrookes commented Mar 4, 2016

@DoubleU23, @chrismcv has kindly agreed to pick this up in one PR, rather than trying to coordinate the two PRs, so going to close this one. Thanks for your contribution!

@mbrookes mbrookes closed this Mar 4, 2016
@DoubleU23 DoubleU23 mentioned this pull request Sep 16, 2016
Closed
@tymochko
Copy link

Hi, is this one released yet? I don't seem to see it in 0.17.4
Really looking forward to have autoFocus for SelectField without DropDownMenu opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrookes mbrookes

Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DoubleU23 @mbrookes @tymochko @oliviertassinari