Transition from css to js for tabs/inkbar #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 11, 2015 20:11
…into css-in-js Conflicts: src/less/components/components.less
|
Closing until fixes |
ghost
closed this
added 6 commits
February 19, 2015 07:36
ghost
reopened this
|
@hai-cea Fixes should be implemented now. Also implemented: Changed fixed width to use % width to allow for resizing/changed functions to pass down left prop to inkbar to reflect this change. As fallout to this change, removed post component mounting check to see if tabWidth*length of total tabs was greater than parent container and forcing back into fixed width. |
|
Also, please remove the less files that were replaced with this PR. |
|
@hai-cea I added mergeandprefix to those files that needed prefixing. Concerning replacing less files - those should already have been replaced in this PR (check tabs.less/ink-bar.less in files changed.) |
hai-cea
pushed a commit
that referenced
this pull request
Feb 25, 2015
Transition from css to js for tabs/inkbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.