[test] Move Firefox tests to CircleCI #34764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 task
oliviertassinari
force-pushed
the
skip-browser-stack-firefox
branch
from
4d6982a to
707d727
Compare
Comment on lines
-37
to
+43
| ['default', 'primary'].forEach((color) => { | ||
| it(`can disable the ripple and hover effect for color ${color}`, () => { | ||
| const { container, getByRole } = render( | ||
| <IconButton disableRipple color={color} TouchRippleProps={{ className: 'touch-ripple' }}> | ||
| book | ||
| </IconButton>, | ||
| ); | ||
| expect(container.querySelector('.touch-ripple')).to.equal(null); | ||
| expect(getComputedStyle(getByRole('button'), ':hover').backgroundColor).to.equal( | ||
| getComputedStyle(getByRole('button')).backgroundColor, | ||
| ); | ||
| }); | ||
| it('can disable the ripple and hover effect', () => { | ||
| const { container } = render( | ||
| <IconButton disableRipple TouchRippleProps={{ className: 'touch-ripple' }}> | ||
| book | ||
| </IconButton>, | ||
| ); | ||
| expect(container.querySelector('.touch-ripple')).to.equal(null); |
There was a problem hiding this comment.
See #29298 (comment) for why some of the assertions are gone. The test was a tautology, so brings no value.
oliviertassinari
requested review from
michaldudak and
mnajdova
as code owners
|
Do you know why the test-browser task fails primarily on the master branch? I haven't seen any problems in PRs, but it's red on a large number of master builds. |
@michaldudak It's because of this, we only run BrowserStack on master: material-ui/test/karma.conf.js Lines 20 to 25 in 31eeb83 |
|
I hope it will help with https://www.notion.so/mui-org/KPIs-1ce9658b85ce4628a2a2ed2ae74ff69c#f36a86b0a0b14d028e744423d9bc6b44
|
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox seems to disconnect quite often looking at the CI runs in https://github.com/mui/material-ui/commits/master, e.g. https://app.circleci.com/pipelines/github/mui/material-ui/82679/workflows/2da72430-6074-47cb-8bbe-e959f815d794/jobs/437658 so why not run Firefox in CircleCI. The one limitation is that we run the latest version (so no correct version compatibility test) but 🤷♂️
Firefox is also slow on BrowserStack relative to the others, maybe why it's unstable:
https://automate.browserstack.com/dashboard/v2/builds/db108dc8dfacc0894749d3eac1271e4d8da8ac4c