[FocusTrap] Convert focus trap to typescript #35005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks for working on this. Could you please also convert the test file to TS? As for the test_static failing, changing the JSDoc of isEnabled in FocusTrap.types.ts to: should help. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@michaldudak , I just finished with the test file and all the checks are passing now. |
michaldudak
reviewed
Dec 14, 2022
Remove casting Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Trizotti <[email protected]>
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Trizotti <[email protected]>
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Trizotti <[email protected]>
|
No problem, @michaldudak ... Thanks for the review. I added the suggested changes. |
michaldudak
reviewed
Dec 15, 2022
| @@ -77,7 +85,7 @@ describe('<FocusTrap />', () => { | |||
| }); | |||
|
|
|||
| it('should warn if the root content is not focusable', () => { | |||
| const UnfocusableDialog = React.forwardRef((_, ref) => <div ref={ref} />); | |||
| const UnfocusableDialog = React.forwardRef<HTMLInputElement>((_, ref) => <div ref={ref} />); | |||
There was a problem hiding this comment.
Shouldn't it be HTMLDivElement?
There was a problem hiding this comment.
You're right. I just fixed it.
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Trizotti <[email protected]>
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Trizotti <[email protected]>
michaldudak
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34722