Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Allows anchor in props table #35543

Closed
wants to merge 1 commit into from

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Dec 20, 2022

It's a recurring problem when answering questions about the data grid. We need to pinpoint some props, but the most precise URL we can provide is: https://mui.com/x/api/data-grid/data-grid/#props

The proposed solution is to let appear an anchor link on hover of the first cell

image

The rows are slightly highlighted when targeted or hover

https://deploy-preview-35543--material-ui.netlify.app/material-ui/api/autocomplete/#props-onHighlightChange

Known CSS issues to fix:

  • do not impact other cells' styling
  • Have the SVG logo correctly centered

@mui-bot
Copy link

mui-bot commented Dec 20, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35543--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 08acd18

@alexfauquette alexfauquette marked this pull request as draft December 20, 2022 14:49
@zannager zannager added the component: table This is the name of the generic UI component, not the React module! label Jan 17, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 2, 2023
@@ -39,6 +44,60 @@ const Table = styled('table')(({ theme }) => {
// as a workaround, use negative margin with overflow `hidden` on the parent
marginLeft: -1,
marginRight: -1,
'.anchor-link-style': { display: 'none' },
tr: {
scrollMarginTop: 'calc(var(--MuiDocs-header-height) + 32px)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might no longer be needed with this fix: #36972 (comment)

@alexfauquette
Copy link
Member Author

Closing this page get a full revamp #37405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants