[Switch] Fix DOM warning when type isn't checkbox or radio

[dani-mp]

Fixes #36111.

• I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Netlify deploy preview

https://deploy-preview-36170--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against ffde56d

[siriwatknp]

@dani-mp Hey, thanks a lot. The fix looks good to me but could you add a test to verify?

[dani-mp]

@siriwatknp the fix is pretty small and IMO it should have been avoided using a linter rule or something like that. Not sure you want tests for every prop you pass to a component in your library.

In any case, I'm curious, how would you test this, given that it's a DOM warning? Can you point me to a place where you do this already?

[michaldudak]

Not sure you want tests for every prop you pass to a component in your library.

We generally want tests for every fixed issue.

In any case, I'm curious, how would you test this, given that it's a DOM warning?

Our tests are set up to fail if there's any error on the console during execution. Simply rendering a switch with a type other than checkbox or radio will be enough.

[siriwatknp]

@dani-mp This should work:

diff --git a/packages/mui-material/src/Switch/Switch.test.js b/packages/mui-material/src/Switch/Switch.test.js
index 1c9a99278c..df8724a5c2 100644
--- a/packages/mui-material/src/Switch/Switch.test.js
+++ b/packages/mui-material/src/Switch/Switch.test.js
@@ -137,4 +137,8 @@ describe('<Switch />', () => {
       });
     });
   });
+
+  it('should not show warnings when custom `type` is provided', () => {
+    expect(() => render(<Switch type="submit" />)).not.toErrorDev();
+  });
 });

[dani-mp]

Done! ✅

[michaldudak]

Thanks a lot! It's a great first PR in Material UI!

[siriwatknp]

👍 Thanks for your time and welcome to MUI contributors. Looking forward to the next PR.