[TextField] Fix floating label position #36288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-36288--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-floating-label
branch
from
e82c0a6 to
100a0c5
Compare
oliviertassinari
force-pushed
the
fix-floating-label
branch
from
100a0c5 to
1e793e5
Compare
oliviertassinari
changed the title
mj12albert
reviewed
Feb 27, 2023
| @@ -184,7 +184,7 @@ const OutlinedInput = React.forwardRef(function OutlinedInput(inProps, ref) { | |||
| label != null && label !== '' && fcs.required ? ( | |||
| <React.Fragment> | |||
| {label} | |||
| {'*'} | |||
|  {'*'} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while I was checking out mui/toolpad#1695, something was looking off visually with the Name input:
as it turns out, the label displayed and the label used for the gutter in the outline don't match:
material-ui/packages/mui-material/src/OutlinedInput/OutlinedInput.js
Line 187 in 17f9fc6
material-ui/packages/mui-material/src/FormLabel/FormLabel.js
Line 113 in 17f9fc6
With this change, it feels better, the gap is more consistent 😌
I checked a bit the history, it was first spotted in #29630 (comment).