Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Keep slot code order in API docs #36499

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 12, 2023

A follow-up on #36490 (comment), this seems to make more sense to communicate the DOM order:

Before
https://mui.com/base/api/slider-unstyled/#slots

After
https://deploy-preview-36499--material-ui.netlify.app/base/api/slider-unstyled/#slots

Ok, for https://mui.com/x/api/data-grid/data-grid/#slots, it doesn't make sense, but they can still sort ASC the properties in the code.

Edit, it seems that it was also requested in #36328 (comment).

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product labels Mar 12, 2023
@mui-bot
Copy link

mui-bot commented Mar 12, 2023

Netlify deploy preview

https://deploy-preview-36499--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 4813fb4

Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the implementation.

@oliviertassinari oliviertassinari merged commit 975ffb8 into mui:master Mar 17, 2023
@oliviertassinari oliviertassinari deleted the retain-slot-order branch March 17, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants