[Joy] Fix --List-decorator* vars
#36595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36595--material-ui.netlify.app/ Bundle size report |
siriwatknp
commented
Mar 21, 2023
Comment on lines
+101
to
+102
| .replace(/--List-decoratorSize/gm, '--ListItemDecorator-size') | ||
| .replace(/--List-decoratorColor/gm, '--ListItemDecorator-color') |
There was a problem hiding this comment.
This is required for projects that already upgraded to 5.0.0-alpha.71.
|
Looks good! Thanks for catching it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformation in https://github.com/mui/material-ui/pull/36282/files#diff-3e64c06413e58efa8d337c4e2e53db6a4fe714613064bc302b702a6ff9bbea79 is wrong.
According to the decision in #35474, it should be:
Before:
--List-decorator-sizeAfter:
--ListItemDecorator-size