Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Introduce *OwnProps interfaces for components #36798

Merged
merged 21 commits into from
Aug 30, 2023
Merged

[typescript] Introduce *OwnProps interfaces for components #36798

merged 21 commits into from
Aug 30, 2023

Conversation

szalonna
Copy link
Contributor

@szalonna szalonna commented Apr 7, 2023 •
edited by michaldudak
Loading

This PR introduces OwnProps in components where the component props are not defined as an augmentable interface while keeping existing exported types or subinterfaces to keep backwards compatibility, as discussed in #36470.

Closes #30507
Closes #36470

@szalonna szalonna changed the title Introduce simple component own props Draft: Introduce *OwnProps interfaces for components Apr 7, 2023
@szalonna szalonna changed the title Draft: Introduce *OwnProps interfaces for components [material] Draft: Introduce *OwnProps interfaces for components Apr 7, 2023
@mui-bot
Copy link

mui-bot commented Apr 7, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36798--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 328dd71

@szalonna szalonna changed the title [material] Draft: Introduce *OwnProps interfaces for components [material] Introduce *OwnProps interfaces for components Apr 7, 2023
@szalonna szalonna changed the title [material] Introduce *OwnProps interfaces for components Introduce *OwnProps interfaces for components Apr 7, 2023
@zannager zannager requested a review from michaldudak April 10, 2023 10:43
@michaldudak michaldudak added package: system Specific to @mui/system package: material-ui Specific to @mui/material labels Apr 12, 2023
@michaldudak michaldudak changed the title Introduce *OwnProps interfaces for components [typescript] Introduce *OwnProps interfaces for components Apr 12, 2023
Jozsef Sebestyen added 2 commits April 12, 2023 22:13
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 14, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 14, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2023
@szalonna
Copy link
Contributor Author

@michaldudak I fixed the changes you requested and have a question

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 9, 2023
@michaldudak
Copy link
Member

Thanks! Would you mind merging in the latest master? I'll do the final review then.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 14, 2023
@szalonna
Copy link
Contributor Author

@michaldudak sorry for the delay, i made the merge

@szalonna szalonna requested a review from michaldudak August 14, 2023 19:27
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 21, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Aug 22, 2023
michaldudak
michaldudak reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! There is a couple of things to correct. Also, please merge in the latest master.

packages/mui-lab/src/LoadingButton/LoadingButton.d.ts Show resolved Hide resolved
packages/mui-lab/src/LoadingButton/LoadingButton.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/Avatar/Avatar.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/CardHeader/CardHeader.d.ts Show resolved Hide resolved
packages/mui-material/src/FormLabel/FormLabel.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/TablePagination/TablePagination.d.ts Outdated Show resolved Hide resolved
@michaldudak
Copy link
Member

@DiegoAndai FYI, we're standardizing to use *OwnProps everywhere.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2023
@szalonna szalonna requested a review from michaldudak August 29, 2023 19:34
michaldudak
michaldudak approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your work!

@michaldudak michaldudak merged commit a2214a7 into mui:master Aug 30, 2023
@szalonna szalonna deleted the ts-extend-component-props branch August 30, 2023 07:14
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@szalonna @mnajdova
[typescript] Introduce *OwnProps interfaces for components (mui#36798)
30c2106
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@szalonna @mnajdova
[typescript] Introduce *OwnProps interfaces for components (mui#36798)
9b39a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material package: system Specific to @mui/system typescript
Projects
None yet
Milestone
No milestone
4 participants
@szalonna @mui-bot @michaldudak @zannager