Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormControl][base] Do not use optional fields in useFormControlContext's return value #37037

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Apr 26, 2023

The docs of the useFormControlContext's return value stated that some fields are optional:

image

This (nor default values) doesn't make much sense in a return value, so I made all the values present.

@michaldudak michaldudak added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base component: FormControl The React component labels Apr 26, 2023
@michaldudak michaldudak requested a review from a team April 26, 2023 13:37
@mui-bot
Copy link

mui-bot commented Apr 26, 2023

Netlify deploy preview

https://deploy-preview-37037--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against d853bcd

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks simpler

@michaldudak michaldudak merged commit 498f55b into mui:master Apr 27, 2023
@michaldudak michaldudak deleted the form-control-api-docs branch April 27, 2023 08:06
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FormControl The React component docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants