-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextareaAutosize] Fix wrong height measurement #37185
Conversation
if the textarea style contain paddingRight and value contain multi line, shadow textarea can't follow the textarea corrently. Signed-off-by: weipeng <[email protected]>
Netlify deploy previewhttps://deploy-preview-37185--material-ui.netlify.app/ Bundle size report |
Please provide a before/after reproduction so we can verify if it's indeed a bug and then test it. |
Looks good! Could you please add a test verifying the fix? |
Certainly! I added a test to verify the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've got some stylistic remarks. Besides that it's OK!
packages/mui-base/src/TextareaAutosize/TextareaAutosize.test.tsx
Outdated
Show resolved
Hide resolved
packages/mui-base/src/TextareaAutosize/TextareaAutosize.test.tsx
Outdated
Show resolved
Hide resolved
Thanks for working on this! |
if the textarea style contain paddingRight and value has multi line, the shadow textarea can't follow the textarea corrently. so we can't overwrite the paddingLeft and paddingRight