[docs][base] FocusTrap basic demo not focusing back to the Box in Firefox #37946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunexplicit <[email protected]>
Netlify deploy previewhttps://deploy-preview-37946--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Co-authored-by: seunexplicit <[email protected]>
|
@ZeeshanTamboli this PR is ready for review |
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
requested changes
Jul 15, 2023
There was a problem hiding this comment.
@gitstart Thanks for the PR. Actually, #37891 was first opened and it was commented in #37866 (comment) that it will be worked on. But there's an issue in that PR hence I am keeping this PR open.
There's the same issue as #37891 (review) in this PR as shown in the screen recording. If you fix it first, we can consider this PR.
Co-authored-by: seunexplicit <[email protected]>
|
Your feedback has been implemented @ZeeshanTamboli, thanks for the consideration. |
|
Thanks for the pull request. I am closing it. See #37891 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On firefox, FocusTrap doesn't refocus on the element.
This implementation addresses that by scrolling the element back into view.
Closes #37866
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.