Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Use Tree View from MUI X in the lab #38261

Merged
merged 11 commits into from
Sep 4, 2023
Merged

[TreeView] Use Tree View from MUI X in the lab #38261

merged 11 commits into from
Sep 4, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Aug 1, 2023 •
edited
Loading

  • Re-export the tree view components from @mui/x-tree-view in @mui/lab and add a warning
  • Use the tree view from @mui/x-tree-view on the landing pages
  • Remove the doc

@flaviendelangle flaviendelangle marked this pull request as draft August 1, 2023 07:50
@mui-bot
Copy link

mui-bot commented Aug 1, 2023 •
edited
Loading

Netlify deploy preview

@material-ui/lab: parsed: +0.79% , gzip: +0.66%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 31fcf29

@flaviendelangle flaviendelangle self-assigned this Aug 1, 2023
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Aug 1, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 1, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 2, 2023
@flaviendelangle flaviendelangle mentioned this pull request Aug 3, 2023
Merged
8 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 7, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 10, 2023
flaviendelangle
flaviendelangle commented Aug 10, 2023
View reviewed changes
packages/mui-lab/src/TreeItem/TreeItem.tsx Outdated
"You should use `import { TreeItem } from '@mui/x-tree-view'`",
"or `import { TreeItem } from '@mui/x-tree-view/TreeItem'`",
'',
'More information about this migration on our blog: INSERT BLOG POST.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not merge this PR before adding the blog post link here (and on the TreeView component)

@flaviendelangle flaviendelangle marked this pull request as ready for review August 10, 2023 07:20
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 14, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Aug 21, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 21, 2023
@flaviendelangle flaviendelangle mentioned this pull request Aug 22, 2023
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 24, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 24, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2023
@oliviertassinari oliviertassinari mentioned this pull request Aug 31, 2023
Closed
1 task
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2023
@flaviendelangle flaviendelangle merged commit ca6998a into mui:master Sep 4, 2023
8 checks passed
@flaviendelangle flaviendelangle deleted the tree-item-reexport branch September 4, 2023 09:34
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@flaviendelangle @mnajdova
[TreeView] Use Tree View from MUI X in the lab (mui#38261)
9938dbd
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@flaviendelangle @mnajdova
[TreeView] Use Tree View from MUI X in the lab (mui#38261)
f131081
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@flaviendelangle @xcode-it
[TreeView] Use Tree View from MUI X in the lab (mui#38261)
4a1c3ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@noraleonte noraleonte Awaiting requested review from noraleonte

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @michaldudak