Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add Tailwind CSS + plain CSS demo on the Input page #38302

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

alisasanib
Copy link
Contributor

Part of #37222

@mui-bot
Copy link

mui-bot commented Aug 3, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 30c59b9

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@alisasanib alisasanib force-pushed the base-input-tailwind-plain-css branch from b619403 to b1b3033 Compare August 3, 2023 13:50
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@alisasanib alisasanib marked this pull request as draft August 3, 2023 14:35
@alisasanib alisasanib marked this pull request as ready for review August 3, 2023 14:48
@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Aug 3, 2023
slotProps={{
input: {
className:
'w-80 text-sm font-normal leading-5 px-3 py-2 rounded-lg shadow-md shadow-slate-100 dark:shadow-slate-900 focus:shadow-outline-purple dark:focus:shadow-outline-purple focus:shadow-lg border border-solid border-slate-300 hover:border-purple-500 dark:hover:border-purple-500 focus:border-purple-500 dark:focus:border-purple-500 dark:border-slate-600 bg-white dark:bg-slate-900 text-slate-900 dark:text-slate-300 focus-visible:outline-0',
Copy link
Member

@oliviertassinari oliviertassinari Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we missed the configuration of the font family in the tailwind.config.js file.

I imagine we should configure Inter to match Joy UI, but we could also configure IBM (one step at a time)?

Off-topic I found a broader bug with font 🙃, reported in #38306.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #38464 for the font family.

@mnajdova mnajdova requested a review from zanivan August 15, 2023 12:02
@mnajdova mnajdova merged commit af37eed into mui:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants