-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add Tailwind CSS + plain CSS demo on the Snackbar, Badge, Switch pages #38425
[docs][base] Add Tailwind CSS + plain CSS demo on the Snackbar, Badge, Switch pages #38425
Conversation
Netlify deploy preview
Bundle size report |
|
||
return ( | ||
<div className={`${isDarkMode ? 'dark' : ''}`}> | ||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zanivan I am not sure about the Tailwind CSS buttons styles, they are too different than the others. Should we update the demos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, all the three styles are too different from the buttons elsewhere. They indeed look great, and similar to the buttons on marketing pages, but I believe we could simplify their design a little and make them similar to what we have on Button demos. I went ahead and made this change, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, we can apply these styles on all demos in a dedicated PR 👍
docs/data/base/components/badge/UnstyledBadgeIntroduction/tailwind/index.tsx
Outdated
Show resolved
Hide resolved
…s introduction, extract Switch component
…hub.com/alisasanib/material-ui into base-snackbar-switch-badge-css-tailwind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Thanks!
Thanks for your comments and review. Shall I continue to update the docs for the remaining components? |
Yes, for introduction demos only please. Two points:
|
Thanks for the comments. I'll consider them for the next demos :) |
Signed-off-by: Marija Najdova <[email protected]>
Part of #37222