Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add Tailwind CSS + plain CSS demo on the Snackbar, Badge, Switch pages #38425

Merged

Conversation

alisasanib
Copy link
Contributor

Part of #37222

@mui-bot
Copy link

mui-bot commented Aug 11, 2023

@alisasanib alisasanib marked this pull request as draft August 11, 2023 16:33
@alisasanib alisasanib marked this pull request as ready for review August 11, 2023 16:52
@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Aug 14, 2023
@zannager zannager requested a review from mnajdova August 14, 2023 10:43

return (
<div className={`${isDarkMode ? 'dark' : ''}`}>
<button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zanivan I am not sure about the Tailwind CSS buttons styles, they are too different than the others. Should we update the demos?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, all the three styles are too different from the buttons elsewhere. They indeed look great, and similar to the buttons on marketing pages, but I believe we could simplify their design a little and make them similar to what we have on Button demos. I went ahead and made this change, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, we can apply these styles on all demos in a dedicated PR 👍

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks!

@alisasanib
Copy link
Contributor Author

Looks good to me now! Thanks!

Thanks for your comments and review. Shall I continue to update the docs for the remaining components?

@mnajdova
Copy link
Member

Thanks for your comments and review. Shall I continue to update the docs for the remaining components?

Yes, for introduction demos only please. Two points:

  • Let's wait for [docs] Use IBM Plex Sans in Tailwind CSS demos #38464 to be merged, it would easy up the rebase :) (I am just waiting for the CI to be green)
  • Please create the custom components by the component name, for e.g. not CustomSlider, but Slider, we can use the Base prefix for the imports from Base UI to resolve the conflict in the names

@alisasanib
Copy link
Contributor Author

Thanks for your comments and review. Shall I continue to update the docs for the remaining components?

Yes, for introduction demos only please. Two points:

  • Let's wait for [docs] Use IBM Plex Sans in Tailwind CSS demos #38464 to be merged, it would easy up the rebase :) (I am just waiting for the CI to be green)
  • Please create the custom components by the component name, for e.g. not CustomSlider, but Slider, we can use the Base prefix for the imports from Base UI to resolve the conflict in the names

Thanks for the comments. I'll consider them for the next demos :)

@mnajdova mnajdova merged commit 91b65ba into mui:master Aug 16, 2023
@alisasanib alisasanib deleted the base-snackbar-switch-badge-css-tailwind branch August 22, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants