Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Hide translation call to action #38449

Merged

Conversation

cristianmacedo
Copy link
Contributor

@cristianmacedo cristianmacedo commented Aug 13, 2023

Hi, I am not sure if you guys are still supporting translations from what I read on #38125, but I decided to create this PR since the FAQ - How can I support the company section still mentions translation as a way to support MUI, and some days ago an non-english speaker friend struggled with the unfinished Portuguese docs.

@mui-bot
Copy link

mui-bot commented Aug 13, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 772b59e

@oliviertassinari oliviertassinari added i18n internationalization docs Improvements or additions to the documentation labels Aug 13, 2023
@oliviertassinari oliviertassinari changed the title Autocomplete docs missing Portuguese translations [docs] Hide translation call to action Aug 13, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 13, 2023

the FAQ - How can I support the company section still mentions translation as a way to support MUI

@cristianmacedo Oh, nice, thanks for surfacing this.

I have updated the PR to remove this mention. As of today, I think it would be great to translate the documentation into Chinese, but we have no plans for any other languages. China is special as even professional developers tend to struggle with English.

@cristianmacedo
Copy link
Contributor Author

cristianmacedo commented Aug 14, 2023

@oliviertassinari Ah great, sounds good!

I forgot to mention that the link to the "translate" page was broken, I see that you also fixed it

@zannager zannager requested a review from mnajdova August 14, 2023 10:46
@cristianmacedo
Copy link
Contributor Author

cristianmacedo commented Aug 16, 2023

Hi, thanks for the approvals!

@siriwatknp siriwatknp merged commit 4294e1d into mui:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation i18n internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants