Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][docs] Updated the List playground demo #38499

Merged
merged 2 commits into from
Aug 17, 2023
Merged

[joy-ui][docs] Updated the List playground demo #38499

merged 2 commits into from
Aug 17, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Aug 16, 2023 •
edited
Loading

Added one more item to the List playground demo
https://deploy-preview-38499--material-ui.netlify.app/joy-ui/react-list/

Before

Screenshot 2023-08-16 at 10 14 22

After

Screenshot 2023-08-16 at 10 14 44

@zanivan zanivan added docs Improvements or additions to the documentation component: list This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Aug 16, 2023
@zanivan zanivan self-assigned this Aug 16, 2023
@zanivan zanivan changed the title [joy-ui][docs] Updated the playground demo [joy-ui][docs] Updated the List playground demo Aug 16, 2023
@zanivan zanivan marked this pull request as draft August 16, 2023 13:17
@mui-bot
Copy link

mui-bot commented Aug 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38499--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 99aea8a

mnajdova
mnajdova approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better 👌

@zanivan
Copy link
Contributor Author

zanivan commented Aug 16, 2023

@siriwatknp I noticed that when you add the variant to <List>, the children items don't pull the same variant or work well with the styling. When adding the solid variant to the we have:
Screenshot 2023-08-16 at 10 34 07
On the other hand, if we add the variant to <List> and <ListItemButton>, we end up having problems with the outlined variant:
Screenshot 2023-08-16 at 10 33 34
As I see, the expected behavior would be similar to what we have on <Select>: https://mui.com/joy-ui/react-select/#introduction

@zanivan zanivan marked this pull request as ready for review August 16, 2023 14:31
@zanivan zanivan merged commit 96c70f0 into mui:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@zanivan zanivan

Labels
component: list This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanivan @mui-bot @mnajdova