[docs-infra] Add light tweaks to the ad container #38504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-38504--material-ui.netlify.app/ Bundle size report |
zanivan
reviewed
Aug 16, 2023
zanivan
approved these changes
Aug 22, 2023
|
I was browsing the docs on HEAD https://master--material-ui.netlify.app/material-ui/react-button/ and noticed that the layout was no longer stable: Screen.Recording.2023-08-23.at.22.38.35.movFixed in #38622 |
|
@oliviertassinari thank you! Did I break that by tweaking the vertical margin? |
|
The origin is mt: 4 -> mt: 3. |
|
Yup! Trying to understand if this one-pixel decrease broke things... guessing the answer is yes? 😬 For the sake of learning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small spacing, fine-tuning, and border styles tweak. Given that the docs have many lines/dividers going on, the more subtle dashed border seems to fit well here, considering the ads already stand out due to their imagery.
https://deploy-preview-38504--material-ui.netlify.app/material-ui/guides/themeable-component/