Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skeleton][material-ui] Soften the pulse animation #38506

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[Skeleton][material-ui] Soften the pulse animation #38506

merged 1 commit into from
Aug 16, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 16, 2023 •
edited
Loading

@oliviertassinari oliviertassinari added package: material-ui Specific to @mui/material component: skeleton This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer labels Aug 16, 2023
@oliviertassinari oliviertassinari marked this pull request as ready for review August 16, 2023 18:30
@mui-bot
Copy link

mui-bot commented Aug 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38506--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2be5155

zanivan
zanivan approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

DiegoAndai
DiegoAndai approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oliviertassinari oliviertassinari merged commit 2753c8e into mui:master Aug 16, 2023
@oliviertassinari oliviertassinari deleted the skeleton-soften-animation branch August 16, 2023 21:26
@oliviertassinari
Copy link
Member Author

https://www.notion.so/mui-org/Olivier-design-review-on-Joy-Design-3ada9a7bcfa44b9fab1fe5032dfb33bb?pvs=4#90493c14531e4ab4a14a923629c9d0cf updated 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: skeleton This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-bot @DiegoAndai @zanivan