[system][zero][tag] Add support for sx prop #38535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38535--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
zero-cssjs-sx
branch
from
4904ce0 to
8b990f1
Compare
mnajdova
changed the title
mnajdova
reviewed
Aug 23, 2023
brijeshb42
force-pushed
the
zero-cssjs-sx
branch
3 times, most recently
from
43ddee8 to
e24a255
Compare
User can pass object or a callback that returns an object. This is done through an intermediate babel-plugin that rewrites the object passed to `sx` prop.
brijeshb42
force-pushed
the
zero-cssjs-sx
branch
from
e24a255 to
00261dd
Compare
mnajdova
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
All the use-cases we have on the demo seem to work, well done 👍
We should look into a simpler way of how we can test this. Should we have somehow the app deployed on netlify? It takes a lot of time to set up everything in order to review a PR. It's fine for now, because mostly I am the reviewer, but when more people will need to be involved, it is going to waste a lot of time.
|
Closes #38754 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can pass object or a callback that returns an object.