[Tabs] Scrollable tabs shouldn't crash when customizing their styles in the theme with slot callbacks #38544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentertz
force-pushed
the
38406-fix-tabs-scrollbar-size
branch
from
0756317 to
f7e3a7f
Compare
Netlify deploy previewhttps://deploy-preview-38544--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
danilo-leal
added
component: tabs
cristianmacedo
approved these changes
Aug 22, 2023
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
@brentertz Thank you for the fix. I added a test to prevent regressions and it looks good to be merged now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38406
This PR supersedes #38524 which was closed due to an issue with Circle CI. I re-forked the Mui repo and created this new PR. Initially the Circle CI issue occurred here as well. I then learned from this support article that I needed to re-authenticate with Circle CI. After doing so, it now seems to be working properly.