-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Polish the Stack page #38623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
component: Stack
The React component.
package: joy-ui
Specific to @mui/joy
labels
Aug 23, 2023
Netlify deploy previewBundle size report |
@siriwatknp + @zanivan it'd be great to have a quick look on this one! |
I liked the way you reordered so the interactive demo is shown first, like the playground demos. I took the liberty to add a tiny visual tweak to one of the demos, but overall looks great! |
zanivan
approved these changes
Aug 31, 2023
saeedShamloo
pushed a commit
to saeedShamloo/material-ui
that referenced
this pull request
Aug 31, 2023
Co-authored-by: zanivan <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Co-authored-by: zanivan <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Co-authored-by: zanivan <[email protected]>
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Co-authored-by: zanivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: Stack
The React component.
docs
Improvements or additions to the documentation
package: joy-ui
Specific to @mui/joy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some polishing to the Joy UI Stack page, making it adhere to the heading hierarchy we've been using it, as well as very light touches on copywriting and the component demos.
https://deploy-preview-38623--material-ui.netlify.app/joy-ui/react-stack/