Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Polish the Stack page #38623

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 23, 2023

This PR does some polishing to the Joy UI Stack page, making it adhere to the heading hierarchy we've been using it, as well as very light touches on copywriting and the component demos.

https://deploy-preview-38623--material-ui.netlify.app/joy-ui/react-stack/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: Stack The React component. package: joy-ui Specific to @mui/joy labels Aug 23, 2023
@danilo-leal danilo-leal self-assigned this Aug 23, 2023
@mui-bot
Copy link

mui-bot commented Aug 23, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ad1d0c0

@danilo-leal
Copy link
Contributor Author

@siriwatknp + @zanivan it'd be great to have a quick look on this one!

@zanivan
Copy link
Contributor

zanivan commented Aug 31, 2023

I liked the way you reordered so the interactive demo is shown first, like the playground demos. I took the liberty to add a tiny visual tweak to one of the demos, but overall looks great!

@danilo-leal danilo-leal merged commit 104b3c0 into mui:master Aug 31, 2023
5 checks passed
@danilo-leal danilo-leal deleted the joy-ui-stack-page-polish branch August 31, 2023 16:50
saeedShamloo pushed a commit to saeedShamloo/material-ui that referenced this pull request Aug 31, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Stack The React component. docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

3 participants