-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Button] Add demo for file upload #38786
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5aba304
[docs] Add upload button demo
anle9650 60938be
add labels
anle9650 5dd103c
Update UploadButtons.js
anle9650 1abb50b
renamed to UploadButton
anle9650 0c73219
Revert "renamed to UploadButton"
anle9650 e8cf42e
rename test labels
anle9650 840cabe
Update buttons.md
anle9650 a169bc1
Update buttons.md
anle9650 c02a2ad
use similar demo as Joy UI
anle9650 914d9ad
place icon at start
anle9650 0df33f0
use contained button variant
anle9650 2a7a207
Update buttons.md
anle9650 05f7e9d
remove tabIndex
anle9650 4d4b7b2
use icon from package
anle9650 5bbd11a
Create InputFileUpload.tsx.preview
anle9650 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import * as React from 'react'; | ||
import { styled } from '@mui/material/styles'; | ||
import Button from '@mui/material/Button'; | ||
import CloudUploadIcon from '@mui/icons-material/CloudUpload'; | ||
|
||
const VisuallyHiddenInput = styled('input')` | ||
clip: rect(0 0 0 0); | ||
clip-path: inset(50%); | ||
height: 1px; | ||
overflow: hidden; | ||
position: absolute; | ||
bottom: 0; | ||
left: 0; | ||
white-space: nowrap; | ||
width: 1px; | ||
`; | ||
|
||
export default function InputFileUpload() { | ||
return ( | ||
<Button | ||
component="label" | ||
variant="contained" | ||
startIcon={<CloudUploadIcon />} | ||
href="#file-upload" | ||
> | ||
Upload a file | ||
<VisuallyHiddenInput type="file" /> | ||
</Button> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import * as React from 'react'; | ||
import { styled } from '@mui/material/styles'; | ||
import Button from '@mui/material/Button'; | ||
import CloudUploadIcon from '@mui/icons-material/CloudUpload'; | ||
|
||
const VisuallyHiddenInput = styled('input')` | ||
clip: rect(0 0 0 0); | ||
clip-path: inset(50%); | ||
height: 1px; | ||
overflow: hidden; | ||
position: absolute; | ||
bottom: 0; | ||
left: 0; | ||
white-space: nowrap; | ||
width: 1px; | ||
`; | ||
|
||
export default function InputFileUpload() { | ||
return ( | ||
<Button | ||
component="label" | ||
variant="contained" | ||
startIcon={<CloudUploadIcon />} | ||
href="#file-upload" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
> | ||
Upload a file | ||
<VisuallyHiddenInput type="file" /> | ||
</Button> | ||
); | ||
} |
9 changes: 9 additions & 0 deletions
9
docs/data/material/components/buttons/InputFileUpload.tsx.preview
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<Button | ||
component="label" | ||
variant="contained" | ||
startIcon={<CloudUploadIcon />} | ||
href="#file-upload" | ||
> | ||
Upload a file | ||
<VisuallyHiddenInput type="file" /> | ||
</Button> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, the standard is for all the demos should use the JavaScript object syntax in Base UI, Joy UI,
Material UI. I imagine it's because 1. the source are written this way, so easier for developers to move between source and demos, and 2. it's more typesafe.
Can we update these?