Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][AccordionGroup] Add missing variant and color classes #38814

Merged
merged 5 commits into from
Sep 12, 2023
Merged

[joy-ui][AccordionGroup] Add missing variant and color classes #38814

merged 5 commits into from
Sep 12, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 5, 2023 •
edited
Loading

closes: #38815

@sai6855 sai6855 marked this pull request as draft September 5, 2023 10:37
@mui-bot
Copy link

mui-bot commented Sep 5, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38814--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 318b08c

@sai6855 sai6855 changed the title Accordion joy classes [joy-ui][AccordionGroup] Add missing variant and color classes Sep 5, 2023
@sai6855 sai6855 marked this pull request as ready for review September 5, 2023 11:33
@sai6855 sai6855 requested a review from siriwatknp September 5, 2023 11:33
@zannager zannager added component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 5, 2023
siriwatknp
siriwatknp approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @sai6855

@sai6855 sai6855 mentioned this pull request Sep 12, 2023
Merged
@DiegoAndai DiegoAndai merged commit 15b0839 into mui:master Sep 12, 2023
10 checks passed
@sai6855 sai6855 deleted the accordion-joy-classes branch September 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[joy-ui][Accordion] AccordionGroup doesn't have variant and color classes
5 participants
@sai6855 @mui-bot @siriwatknp @DiegoAndai @zannager