[docs-infra] Improve show code button affordance #38824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-38824--material-ui.netlify.app/ Bundle size report |
|
@trungutt I'd appreciate you chiming in here and sharing what you think about this change! :) |
|
Thanks for involving me in the preview. It does look a lot better, with the outlined and color changes. Really appreciate it 👍 Screen.Recording.2023-09-11.at.14.05.56.mov |
|
Nice, love the consistency look with the TS/JS button. |
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38722
This PR is another iteration of improving the affordance of the "Show code" buttons on the demo's toolbar. The above-linked issue came from a community contributor saying how the recent change from the
<>icon button to the gray labeled button made it confusing to understand that it was clickable. Here, we're adding a slight border and also turning the label blue to really indicate that's an action visitors can take. Hopefully, this will kick the amount of events this action was triggering back up and improve the UX.Examples below: