Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump aws-cli orb to 4.1 #38857

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[core] Bump aws-cli orb to 4.1 #38857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b458eba
Update config.yml
Janpot Sep 7, 2023
7710734
Update config.yml
Janpot Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: 2.1
orbs:
aws-cli: circleci/aws-cli@4.0
aws-cli: circleci/aws-cli@4.1
aws-s3: circleci/[email protected]

parameters:
Expand Down Expand Up @@ -689,9 +689,9 @@ jobs:
value: << pipeline.git.branch >>
steps:
- aws-cli/setup:
aws_access_key_id: AWS_ACCESS_KEY_ID_ARTIFACTS
region: AWS_REGION_ARTIFACTS
aws_secret_access_key: AWS_SECRET_ACCESS_KEY_ARTIFACTS
aws_access_key_id: $AWS_ACCESS_KEY_ID_ARTIFACTS
region: $AWS_REGION_ARTIFACTS
aws_secret_access_key: $AWS_SECRET_ACCESS_KEY_ARTIFACTS
# Upload distributables to S3
- aws-s3/copy:
from: mui-material.tgz
Expand All @@ -718,9 +718,9 @@ jobs:
value: << pipeline.git.branch >>
steps:
- aws-cli/setup:
aws_access_key_id: AWS_ACCESS_KEY_ID_ARTIFACTS
region: AWS_REGION_ARTIFACTS
aws_secret_access_key: AWS_SECRET_ACCESS_KEY_ARTIFACTS
aws_access_key_id: $AWS_ACCESS_KEY_ID_ARTIFACTS
Copy link
Member

@oliviertassinari oliviertassinari Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be correct?

Suggested change
aws_access_key_id: $AWS_ACCESS_KEY_ID_ARTIFACTS
aws_access_key_id: ${AWS_ACCESS_KEY_ID_ARTIFACTS}

But not sure, seems to not matter https://stackoverflow.com/questions/8748831/when-do-we-need-curly-braces-around-shell-variables

This comment was marked as outdated.

Sign in to view

region: $AWS_REGION_ARTIFACTS
aws_secret_access_key: $AWS_SECRET_ACCESS_KEY_ARTIFACTS
# persist size snapshot on S3
- aws-s3/copy:
arguments: --content-type application/json
Expand Down