Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clearer npm package homepages #38864

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 8, 2023

When looking at https://www.npmjs.com/package/next, https://www.npmjs.com/package/react, the homepage points you to the homepage of each project so I think we could do the same.

e.g. https://www.npmjs.com/package/@mui/joy, so strange:

Screenshot 2023-09-08 at 03 03 54

I noticed this from ericdiviney/react-handbook#89.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 8, 2023
@mui-bot
Copy link

mui-bot commented Sep 8, 2023

Netlify deploy preview

https://deploy-preview-38864--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ca41e1b

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! 🤙

Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

@oliviertassinari oliviertassinari merged commit de79636 into mui:master Sep 8, 2023
6 checks passed
@oliviertassinari oliviertassinari deleted the npm-package-link branch September 8, 2023 18:58
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants