-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal][material] Fix console warning when onTransitionEnter , onTransitionExit provided #38868
Conversation
Netlify deploy previewhttps://deploy-preview-38868--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. We make sure they are not spread when using the getRootProps
callback, but here they are spread as part of the other
. One more benefit of being able to send all props to the getSlotProps
callbacks - we can intercept props that should not be propagated further cc @mj12albert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping into this one @sai6855! 🎉
…sitionExit provided (mui#38868)
@sai6855 this pull request was a duplicate of #38745. For more trivial fixes, we can allow first-time contributors or some contributors that are not that active to pick them up. It would have been much better if you'd reviewed the other pull request, rather than creating the pull request yourself. A note for next time - check if there is an ongoing pull request and link it with the original issue - this will help with not picking up duplicate work. |
Oh, since PR wasn't linked to the issue I wasn't aware of that pr . If it was linked i wouldn't touch the issue or create new PR. Also PR was opened before issue was created so there is very little chance that i would be aware of that PR. But from next time i'll be bit more careful |
closes: #38843
before: https://codesandbox.io/s/mui-swipabledrawer-example-new-7pnch2
after: https://codesandbox.io/s/affectionate-hooks-vwlqrk
Base
Modal
extractedonTransitionEntered
,onTransitionExited
here fromprops
before passing to useSlotProps here. That's why same error didn't occured inBaseUI
Modal
. This PR follows same implemetation asBaseUI
Modal
to fix the warning