Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove package declaration from same package dependencies #38951

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Sep 13, 2023

In #38859, dependencies were explicitly added to packages. Some declared themselves as a dependency. lerna does not update these versions, causing mismatches. For example from the v5.14.9 release PR, after update @mui/base ended up with "version": "5.0.0-beta.15" and "@mui/base": "5.0.0-beta.14" as a dependency.

@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Sep 13, 2023
@DiegoAndai DiegoAndai self-assigned this Sep 13, 2023
@DiegoAndai DiegoAndai marked this pull request as ready for review September 13, 2023 11:39
@mui-bot
Copy link

mui-bot commented Sep 13, 2023

Netlify deploy preview

https://deploy-preview-38951--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ad7726d

@DiegoAndai DiegoAndai merged commit 62dfa47 into mui:master Sep 13, 2023
6 checks passed
@DiegoAndai DiegoAndai deleted the remove-same-package-from-deps branch September 13, 2023 12:28
@DiegoAndai DiegoAndai mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants