[docs-infra] Remove overflow: hidden for demo gradient bg #39225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
| @@ -198,7 +198,6 @@ const DemoRootMaterial = styled('div', { | |||
| shouldForwardProp: (prop) => prop !== 'hideToolbar' && prop !== 'bg', | |||
| })(({ theme, hideToolbar, bg }) => ({ | |||
| position: 'relative', | |||
| outline: 0, | |||
There was a problem hiding this comment.
Legacy, we can't focus this container anymore
Netlify deploy previewhttps://deploy-preview-39225--material-ui.netlify.app/ Bundle size report |
|
Merged as there seems to be no downsides to this change. Actually, I think that we can broaden the topic on how we want to manage the |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this from #39176. Open https://mui.com/base-ui/react-tabs/#introduction, no scrollbar:
IMHO, we should almost never use
overflow: hiddenbut there are rare valid ones e.g. skeleton animation background.Now, in my example, we should also likely fix the demo itself, but here, my goal is to have better behavior when it goes wrong, and make it feel less broken.
Preview: https://deploy-preview-39225--material-ui.netlify.app/base-ui/react-tabs/#introduction