Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Deprecate the valueLink property #3936

Merged
merged 2 commits into from
Apr 18, 2016
Merged

[List] Deprecate the valueLink property #3936

merged 2 commits into from
Apr 18, 2016

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 11, 2016 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Start addressing #2880.

  • Deprecate the valueLink API
  • Migrate the component to the ES6 class API
  • Add some test using the assert.equal way as we do with our unit test

oliviertassinari
oliviertassinari reviewed Apr 11, 2016
View reviewed changes
docs/src/app/components/pages/components/List/SelectableHelp.md
@@ -1,41 +0,0 @@
## Selectable List
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing can beat a good example 😁.

@oliviertassinari oliviertassinari added this to the 0.15.0 Release milestone Apr 11, 2016
@oliviertassinari oliviertassinari merged commit 002b04e into mui:master Apr 18, 2016
@oliviertassinari oliviertassinari deleted the value-link-make-selecatable branch April 18, 2016 18:53
@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
0.15.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @zannager