Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Improve Dialog demos #39642

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[docs][material-ui] Improve Dialog demos #39642

merged 2 commits into from
Oct 30, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Oct 28, 2023 •
edited
Loading

Preview - https://deploy-preview-39642--material-ui.netlify.app/material-ui/react-dialog/

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Oct 28, 2023
@mui-bot
Copy link

mui-bot commented Oct 28, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39642--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 25f8903

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review October 28, 2023 10:35
samuelsycamore
samuelsycamore approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it!

@ZeeshanTamboli ZeeshanTamboli merged commit 8eb3c1f into mui:master Oct 30, 2023
9 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the improve-material-ui-dialog-demos branch October 30, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeshanTamboli @mui-bot @samuelsycamore