[blog] Add a Phuket retreat blog post #40055
Conversation
A blog post to recap our time together in Thailand.
Netlify deploy previewhttps://deploy-preview-40055--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
It's always a pleasure to review the latest writing from @mikailaread ! Normally I would request that authors add soft line breaks to their Markdown to make line-by-line reviews easier, but with your writing I know that I won't really need that convenience on my end so I don't mind. Nice work! I look forward to seeing the photos once you upload them!
Adding photos to blog folder for Phuket retreat blog.
Accepting Sam's brilliant edits. Thank you! Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: mikailaread <[email protected]>
…material-ui into 2023-phuket-retreat
Right - I think I have successfully uploaded the photos but am receiving an "Unable to render rich display message" across most of them. Any ideas where I've gone wrong here? Github Desktop suggests they uploaded fine. Then again, in my VSC, I'm also getting a "command 'markdown.showPreview' not found" error message when I try to preview them there using CMD + Shift + V. 🤔 
|
There was a problem hiding this comment.
Woo, this looks amazing! Always fun to see you pushing pull requests! 🎉
Pushed a few changes fixing some blog styles here and there, as well as compressing the images! I think the problem you mentioned above was because the original images were heavy 😅 As a rule of thumb, having them with at least less than 1MB is ideal. Aside from this, everything looks great! I tentatively put the date of publication for 12/13, but there’s a chance it gets delayed a bit depending on the next week’s release.
Woohoo 🙌 Oh gosh, yeah. The image sizes were enormous for this one. Good to know and for next time, I'll be sure to compress them first. No worries about the publication date but would be great to get alerted when it's live so we can push on social media too. 🙏 Thank you both as always for the great edits and support! I think this wrap up blog is much better than the last one. @samuelsycamore & @danilo-leal 💙 |
| borderRadius: 4, | ||
| border: '1px solid', | ||
| borderColor: (theme.vars || theme).palette.grey[200], | ||
| borderRadius: 12, |
There was a problem hiding this comment.
A note to acknowledge the impact of this style on other blog posts, e.g. https://deploy-preview-40055--material-ui.netlify.app/blog/mui-x-end-v6-features/. There are two cases where it can feel a bit weird:
- The image already have a border, it conflicts, too heavy border or mismatching border radiuses
- The image already has internal borders, it feels heavy
I don't have a specific preference on how to move forward, I see two options:
- Remove the border with inline style for the cases where it's wrong (mostly for new blog posts)
- Add the border on an ad-hoc basis
I guess 1. makes sense as it allows to more easily update the whole docs feel. To keep an eye on either 2. is a better default or not.
There was a problem hiding this comment.
Yeah, you got it, I'm keeping track of these cases! I'll soon put up a PR doing a general image review on all blog posts (including images from the posts themselves as well as standardizing the open graph card image that has since grown inconsistent over the many design iterations I played around with). 😬
A blog post to recap our time together in Thailand.
https://deploy-preview-40055--material-ui.netlify.app/blog/2023-phuket-retreat/